Refactor: move d.ts file #1749
Merged
Refactor: move d.ts file #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for react-redux-docs ready! 🔨 Explore the source changes: 984ec25 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-redux-docs/deploys/60dc8c0b11cbd700073d7ad0 😎 Browse the preview: https://deploy-preview-1749--react-redux-docs.netlify.app |
|
Yeah, I'd rather have it here. Thanks! |
|
I'm fine with just picking these individual types for now. We can look at pulling in the complete types files later if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @markerikson
Relating to your last comment #1746 (comment), i have made a small change to avoid any possible problems. The custom types for the external dependencies will be outside of src and they will be ignored from the build process.
I'm not so sure if it's worth having these custom types, maybe it would be easier to install the @types/* of these dependencies. What do you think?