Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove connectAdvanced #1771

Merged
merged 14 commits into from Sep 4, 2021
Merged

Remove connectAdvanced #1771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
69d9df4
Add additional comments to connectAdvanced
markerikson Jul 18, 2021
c932ea3
Fix types for wrapper props args
markerikson Jul 18, 2021
28bd86e
Remove dead code
markerikson Jul 18, 2021
2a6b927
Eliminate useless `createConnect` wrapper
markerikson Jul 18, 2021
2dd0af2
Remove connectAdvanced exports
markerikson Jul 18, 2021
29f0efa
Formatting
markerikson Jul 18, 2021
7e55217
Remove methodName option
markerikson Jul 18, 2021
a57dc19
Remove displayName option
markerikson Jul 18, 2021
cb82af2
Remove connectAdvanced tests
markerikson Jul 18, 2021
ae97b09
Consolidate connect logic into one file
markerikson Jul 18, 2021
75b4bdd
Rename connectAdvanced to connect
markerikson Jul 18, 2021
532f696
Consolidate connect implementation
markerikson Jul 18, 2021
c7c2f0c
Merge branch 'master' into feature/remove-connectadvanced
markerikson Jul 28, 2021
c7b1bc1
Merge branch 'master' into feature/remove-connectadvanced
markerikson Sep 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Provider.tsx
View file
Open in desktop
Expand Up @@ -12,8 +12,8 @@ export interface ProviderProps<A extends Action = AnyAction> {
store: Store<FixTypeLater, A>
/**
* Optional context to be used internally in react-redux. Use React.createContext() to create a context to be used.
* If this is used, generate own connect HOC by using connectAdvanced, supplying the same context provided to the
* Provider. Initial value doesn't matter, as it is overwritten with the internal state of Provider.
* If this is used, you'll need to customize `connect` by supplying the same context provided to the Provider.
* Initial value doesn't matter, as it is overwritten with the internal state of Provider.
*/
context?: Context<ReactReduxContextValue | null>
children: ReactNode
Expand Down