Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: transform test/integration/server-rendering => ts #1776

Merged

Conversation

myNameIsDu
Copy link
Contributor

transform test/integration/server-rendering => ts

ref: #1737

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 938b18e:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

@netlify
Copy link

netlify bot commented Jul 23, 2021

✔️ Deploy Preview for react-redux-docs ready!

🔨 Explore the source changes: 938b18e

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-redux-docs/deploys/60fa95510510670008497534

😎 Browse the preview: https://deploy-preview-1776--react-redux-docs.netlify.app

greeting: string
greeted: string
}
const Greeting: FunctionComponent<GreetingProps> = ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✋ I don't think FunctionComponent is actually needed here - just use GreetingProps after the destructuring. But we can get this in now and tweak stuff later.

(Then again, we could probably replace a lot of our classes with functions anyway)

@markerikson
Copy link
Contributor

Thanks!

@markerikson markerikson merged commit 9e6793a into reduxjs:typescript-port Jul 23, 2021
@myNameIsDu myNameIsDu deleted the refactor/test-server-rendering branch July 27, 2021 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants