Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: transform test/connect to ts #1779

Closed

Conversation

myNameIsDu
Copy link
Contributor

transform test/connect to ts

link: #1737

@myNameIsDu myNameIsDu marked this pull request as draft July 28, 2021 03:54
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 28, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b1fdf0b:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

@netlify
Copy link

netlify bot commented Jul 28, 2021

✔️ Deploy Preview for react-redux-docs ready!

🔨 Explore the source changes: b1fdf0b

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-redux-docs/deploys/61010890199ce700082529cc

😎 Browse the preview: https://deploy-preview-1779--react-redux-docs.netlify.app

@myNameIsDu
Copy link
Contributor Author

myNameIsDu commented Jul 28, 2021

@markerikson Since this file is relatively large, I want to let you review it first, so that you can find out the problem of my writing method earlier 😃

@markerikson
Copy link
Contributor

So just to confirm, the rest of the file is temporarily commented out until you get a thumbs-up from me on the approach?

The code seems reasonable so far, so go ahead.

FYI, I think I'm just going to go ahead and merge the typescript-port branch into master right now. We can update this PR to base against master after that.

@markerikson markerikson deleted the branch reduxjs:typescript-port July 28, 2021 22:46
@markerikson
Copy link
Contributor

Bah, Github auto-closed this because I merged and it deleted that branch. Fixing and pointing this at master

@markerikson
Copy link
Contributor

Drat. It won't let me edit the base or reopen this PR.

Can you please open up a new PR targeting master with your changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants