refactor: transform react-native => ts & modify jestConfig: delete th… #1786
Conversation
…e JS matching pattern
|
✔️ Deploy Preview for react-redux-docs ready! 🔨 Explore the source changes: 22589e6 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-redux-docs/deploys/6108093573984f0008e3aab2 😎 Browse the preview: https://deploy-preview-1786--react-redux-docs.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 22589e6:
|
| const button = rendered.getByTestId(testID) | ||
| rtl.fireEvent.press(button) | ||
| } | ||
|
|
||
| const clickAndRender = (rendered, testID) => { | ||
| const clickAndRender = (rendered: RenderedType) => { | ||
| // Note: Normally we'd wrap this all in act(), but that automatically | ||
| // wraps your code in batchedUpdates(). The point of this bug is that it | ||
| // specifically occurs when you are _not_ batching updates! | ||
| clickButton(rendered, 'setTimeout') |
There was a problem hiding this comment.
✋ Yeah, I think there's actually a bug in this test here. It should be clickButton(rendered, testID) - I apparently missed passing that through when I was writing this :)
Can you restore the arguments for this section and fix this line?
|
Looks good, thanks! |
refactor: transform react-native => ts & modify jestConfig: delete the JS matching pattern
link #1737
there is a problem:
In this case, I've deleted the previous argument