Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency on loadsh-es #908

Merged
merged 1 commit into from Mar 27, 2018
Merged

Conversation

thomaswelton
Copy link
Contributor

Recent versions of lodash-es were affected by a bug in NPM where by it set the timestamps of files to sometime in the 1970's which causes a problem when trying to create a zip file of the node_modules

See the released issues here.
yarnpkg/yarn#5577
lodash/lodash#3714

Lodash was republished with a newer version of NPM which fixes this issue.
This PR update just contains the result of npm update loads-es

@jimbolla
Copy link
Contributor

Shouldn't package.json be updated as well then?

@thomaswelton
Copy link
Contributor Author

It's not required, the package.json contains ^4.17.5
If you're running an old version of npm which ignores the lock file then you'll just get the latest minor release of 4.17 which right now would be 4.17.8
But for new versions of npm you can only get when is in the lock file

@timdorr
Copy link
Member

timdorr commented Mar 27, 2018

Thanks!

@timdorr timdorr merged commit d103e3e into reduxjs:master Mar 27, 2018
josepot pushed a commit to josepot/react-redux-lean that referenced this pull request Sep 21, 2018
webguru7 pushed a commit to webguru7/react-redux that referenced this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants