Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use React.createContext() by @markerikson #995

Closed
wants to merge 13 commits into from
Closed

Use React.createContext() by @markerikson #995

wants to merge 13 commits into from

Commits on Aug 14, 2018

  1. Copy changes from original v6 experiment branch

    @markerikson
    markerikson committed Aug 14, 2018
    Copy the full SHA
    4e654e2 View commit details
    Browse the repository at this point in the history

  2. Split Connect into two wrapper components

    @markerikson
    markerikson committed Aug 14, 2018
    Copy the full SHA
    31fc951 View commit details
    Browse the repository at this point in the history

  3. Clean up and finish reworking Connect and Provider

    @markerikson
    markerikson committed Aug 14, 2018
    Copy the full SHA
    0374936 View commit details
    Browse the repository at this point in the history

  4. Don't call setState in Provider if unmounting

    @markerikson
    markerikson committed Aug 14, 2018
    Copy the full SHA
    a64103c View commit details
    Browse the repository at this point in the history

  5. Rework tests based on changes to connect and Provider

    @markerikson
    markerikson committed Aug 14, 2018
    Copy the full SHA
    ed7a910 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2018

  1. Fix lint errors

    @markerikson
    markerikson committed Aug 18, 2018
    Copy the full SHA
    3cf4a0f View commit details
    Browse the repository at this point in the history

  2. Add react-is

    @markerikson
    markerikson committed Aug 18, 2018
    Copy the full SHA
    6bfedb1 View commit details
    Browse the repository at this point in the history

  3. Add missing functionality for connect and Provider 

    Added ability to swap stores
Removed single-child limitation

Added invariant warnings for storeKey and withRef
Added valid element check using react-is
Refactored child selector creation for reusability
Added prop types for components
Added forwardRef and consumer as prop capability
Added a tiny memoized function for wrapper props handling
Removed semicolons
    @markerikson
    markerikson committed Aug 18, 2018
    Copy the full SHA
    5df5a0f View commit details
    Browse the repository at this point in the history

  4. Borrow a bunch of tests from Greg's 1000 branch

    @markerikson
    markerikson committed Aug 18, 2018
    Copy the full SHA
    1fe01d0 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2018

  1. Include react-is in build output

    @markerikson
    markerikson committed Aug 24, 2018
    Copy the full SHA
    0d0360f View commit details
    Browse the repository at this point in the history

  2. Try using a functional component instead of forwardRef

    @markerikson
    markerikson committed Aug 24, 2018
    Copy the full SHA
    577efb0 View commit details
    Browse the repository at this point in the history

  3. Temporarily undo all connect wrappings

    @markerikson
    markerikson committed Aug 24, 2018
    Copy the full SHA
    7f72494 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2018

  1. Make forwardRef optional

    @markerikson
    markerikson committed Sep 13, 2018
    Copy the full SHA
    9210282 View commit details
    Browse the repository at this point in the history