Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call useIsomorphicLayoutEffect to fix warning #1319

Merged
merged 1 commit into from Jul 17, 2021

Conversation

markerikson
Copy link
Collaborator

This PR:

  • Copy-pastes the definition of useIsomorphicLayoutEffect from react-redux
  • Replaces the one usage of useLayoutEffect with useIsomorphicLayoutEffect to avoid warnings in SSR

Fixes #1173 .

@netlify
Copy link

netlify bot commented Jul 17, 2021

✔️ Deploy Preview for redux-starter-kit-docs ready!

🔨 Explore the source changes: e17e0c3

🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/60f3659186e4e50007b95b72

😎 Browse the preview: https://deploy-preview-1319--redux-starter-kit-docs.netlify.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e17e0c3:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration

@github-actions
Copy link

size-limit report 📦

Path Size
1. entry point: @reduxjs/toolkit (cjs.production.min.js) 12.21 KB (0%)
1. entry point: @reduxjs/toolkit (esm.js) 10.21 KB (0%)
1. entry point: @reduxjs/toolkit/query (cjs.production.min.js) 20.31 KB (0%)
1. entry point: @reduxjs/toolkit/query (esm.js) 17.35 KB (0%)
1. entry point: @reduxjs/toolkit/query/react (cjs.production.min.js) 22.18 KB (+0.08% 🔺)
1. entry point: @reduxjs/toolkit/query/react (esm.js) 19.79 KB (+0.11% 🔺)
2. entry point: @reduxjs/toolkit (without dependencies) (cjs.production.min.js) 5.55 KB (0%)
2. entry point: @reduxjs/toolkit (without dependencies) (esm.js) 5.53 KB (0%)
2. entry point: @reduxjs/toolkit/query (without dependencies) (cjs.production.min.js) 9.19 KB (0%)
2. entry point: @reduxjs/toolkit/query (without dependencies) (esm.js) 9.56 KB (0%)
2. entry point: @reduxjs/toolkit/query/react (without dependencies) (cjs.production.min.js) 2.36 KB (+1.56% 🔺)
2. entry point: @reduxjs/toolkit/query/react (without dependencies) (esm.js) 2.21 KB (+1.58% 🔺)
3. createSlice (esm.js) 5.15 KB (0%)
3. createEntityAdapter (esm.js) 5.82 KB (0%)
3. configureStore (esm.js) 5.83 KB (0%)
3. createApi (esm.js) 15.64 KB (0%)
3. createApi (react) (esm.js) 18.02 KB (+0.16% 🔺)
3. fetchBaseQuery (esm.js) 10.91 KB (0%)
3. setupListeners (esm.js) 9.78 KB (0%)
3. ApiProvider (esm.js) 16.96 KB (+0.17% 🔺)

@markerikson markerikson merged commit 28e201c into master Jul 17, 2021
@markerikson markerikson deleted the bugfix/uselayout-warnings branch July 17, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTKQ: Warning with NextJs
1 participant