Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .withTypes to createDraftSafeSelector #4080

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 11 additions & 7 deletions packages/toolkit/src/createDraftSafeSelector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,17 @@ export const createDraftSafeSelectorCreator: typeof createSelectorCreator = (
...args: unknown[]
) => {
const createSelector = (createSelectorCreator as any)(...args)
return (...args: unknown[]) => {
const selector = createSelector(...args)
const wrappedSelector = (value: unknown, ...rest: unknown[]) =>
selector(isDraft(value) ? current(value) : value, ...rest)
Object.assign(wrappedSelector, selector)
return wrappedSelector as any
}
const createDraftSafeSelector = Object.assign(
(...args: unknown[]) => {
const selector = createSelector(...args)
const wrappedSelector = (value: unknown, ...rest: unknown[]) =>
selector(isDraft(value) ? current(value) : value, ...rest)
Object.assign(wrappedSelector, selector)
return wrappedSelector as any
},
{ withTypes: () => createDraftSafeSelector }
)
return createDraftSafeSelector
}

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
import { createDraftSafeSelector } from '@reduxjs/toolkit'

interface Todo {
id: number
completed: boolean
}

interface Alert {
id: number
read: boolean
}

interface RootState {
todos: Todo[]
alerts: Alert[]
}

const rootState: RootState = {
todos: [
{ id: 0, completed: false },
{ id: 1, completed: false },
],
alerts: [
{ id: 0, read: false },
{ id: 1, read: false },
],
}

describe(createDraftSafeSelector.withTypes, () => {
const createTypedDraftSafeSelector =
createDraftSafeSelector.withTypes<RootState>()

test('should return createDraftSafeSelector', () => {
expect(createTypedDraftSafeSelector.withTypes).toEqual(expect.any(Function))

expect(createTypedDraftSafeSelector.withTypes().withTypes).toEqual(
expect.any(Function)
)

expect(createTypedDraftSafeSelector).toBe(createDraftSafeSelector)

const selectTodoIds = createTypedDraftSafeSelector(
[(state) => state.todos],
(todos) => todos.map(({ id }) => id)
)

expect(selectTodoIds(rootState)).to.be.an('array').that.is.not.empty
})
})