New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centralize tooling configs in monorepo #4138
base: master
Are you sure you want to change the base?
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 61feea6:
|
Okay, what I think I'm seeing here is:
Can I get a summary of what lint rules changed? Also it looks like there's some commented out lint rules in the ESLint config |
Sure, so mostly what I did was, add 2 configs:
Along with |
could you add a |
Yeah sure! |
- This change was made because `@reduxjs/eslint-config` includes the `typescript-eslint` package as a direct dependency which includes `@typescript-eslint/eslint-plugin` and `@typescript-eslint/parser` as direct dependencies so there is no need to manually install them anymore.
This PR: