Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oazapfts to 6.0.2 #4198

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SimonEggert
Copy link

@SimonEggert SimonEggert commented Feb 14, 2024

Some issues (s. #3814) have been fixed in upstream library oazapfts so this is an attempt to update it to the latest version.

The major updates that this update has stepped over are mainly regarding changes to exported files that have been addressed by this PR.

oazapfts now includes comments in the generated types, so I also needed to update the snapshot tests.

closes #3814

Copy link

codesandbox bot commented Feb 14, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 7939056
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/660e97add64165000888e8df
😎 Deploy Preview https://deploy-preview-4198--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codesandbox-ci bot commented Feb 14, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7939056:

Sandbox Source
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes were necessary to fix errors regarding the new import structure that does not seem to work (for TypeScript at least), s. this workflow run. I am not fully aware of the implications this might have for building and packaging, so please take a closer look.

@mattoni
Copy link

mattoni commented Apr 1, 2024

Any update to this? Definitely would love to have the updates to oazapfts :)

@SimonEggert
Copy link
Author

I am trying to keep this PR up to date with master to keep it reviewable, but I haven't heard back.

@markerikson, you have responded in the corresponding issue a while ago. Any chance you could look into this PR any time soon? I'd be glad to rework anything that prevents this PR from being merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rtk-query-codegen-openapi: Null values not always respected
2 participants