Fix incorrect legacy-esm target #4284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c9110af:
|
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
size-limit report 📦
|
github-merge-queue bot
pushed a commit
to coveo/ui-kit
that referenced
this pull request
Mar 26, 2024
) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@reduxjs/toolkit](https://redux-toolkit.js.org) ([source](https://togithub.com/reduxjs/redux-toolkit)) | [`2.2.1` -> `2.2.2`](https://renovatebot.com/diffs/npm/@reduxjs%2ftoolkit/2.2.1/2.2.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>reduxjs/redux-toolkit (@​reduxjs/toolkit)</summary> ### [`v2.2.2`](https://togithub.com/reduxjs/redux-toolkit/releases/tag/v2.2.2) [Compare Source](https://togithub.com/reduxjs/redux-toolkit/compare/v2.2.1...v2.2.2) This patch release fixes an incorrect build setting for the `legacy-esm` artifacts, and fixes an issue with RTKQ query hooks didn't always remove the cache entries if arguments were changed rapidly. #### Changes ##### `legacy-esm` Artifact Transpilation The `legacy-esm` build artifacts are intended for use by Webpack 4. Those were *supposed* to be transpiled to target `"es2017"`, but were in fact still set to target `"esnext"` - an oversight during the 2.0 development cycle. This release fixes that setting, so those artifacts are now correctly transpiled. ##### Other Fixes RTKQ query hooks now handle additional actions around argument changes that should result in cache entries being removed. Additionally, 2.2.1 contained a fix to an incorrectly named type: `TypedUseMutationTrigger` is now `TypedMutationTrigger`. #### What's Changed - rename TypedUseMutationTrigger to TypedMutationTrigger, and add deprecated alias by [@​EskiMojo14](https://togithub.com/EskiMojo14) in [reduxjs/redux-toolkit#4204 - Fixed memory leak in rapid hook arg changing by [@​riqts](https://togithub.com/riqts) in [reduxjs/redux-toolkit#4268 - Fix incorrect legacy-esm target by [@​markerikson](https://togithub.com/markerikson) in [reduxjs/redux-toolkit#4284 **Full Changelog**: reduxjs/redux-toolkit@v2.2.0...v2.2.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/coveo/ui-kit). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
github-merge-queue bot
pushed a commit
to valora-inc/wallet
that referenced
this pull request
Mar 26, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@reduxjs/toolkit](https://redux-toolkit.js.org) ([source](https://togithub.com/reduxjs/redux-toolkit)) | [`^2.2.1` -> `^2.2.2`](https://renovatebot.com/diffs/npm/@reduxjs%2ftoolkit/2.2.1/2.2.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>reduxjs/redux-toolkit (@​reduxjs/toolkit)</summary> ### [`v2.2.2`](https://togithub.com/reduxjs/redux-toolkit/releases/tag/v2.2.2) [Compare Source](https://togithub.com/reduxjs/redux-toolkit/compare/v2.2.1...v2.2.2) This patch release fixes an incorrect build setting for the `legacy-esm` artifacts, and fixes an issue with RTKQ query hooks didn't always remove the cache entries if arguments were changed rapidly. #### Changes ##### `legacy-esm` Artifact Transpilation The `legacy-esm` build artifacts are intended for use by Webpack 4. Those were *supposed* to be transpiled to target `"es2017"`, but were in fact still set to target `"esnext"` - an oversight during the 2.0 development cycle. This release fixes that setting, so those artifacts are now correctly transpiled. ##### Other Fixes RTKQ query hooks now handle additional actions around argument changes that should result in cache entries being removed. Additionally, 2.2.1 contained a fix to an incorrectly named type: `TypedUseMutationTrigger` is now `TypedMutationTrigger`. #### What's Changed - rename TypedUseMutationTrigger to TypedMutationTrigger, and add deprecated alias by [@​EskiMojo14](https://togithub.com/EskiMojo14) in [reduxjs/redux-toolkit#4204 - Fixed memory leak in rapid hook arg changing by [@​riqts](https://togithub.com/riqts) in [reduxjs/redux-toolkit#4268 - Fix incorrect legacy-esm target by [@​markerikson](https://togithub.com/markerikson) in [reduxjs/redux-toolkit#4284 **Full Changelog**: reduxjs/redux-toolkit@v2.2.0...v2.2.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
legacy-esmbuilds, which were somehow set to"esnext"and not"es2017"(totally on me apparently)errors.jsonFixes #4282