Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use esbuild for bundling #962

Closed
wants to merge 1 commit into from
Closed

Use esbuild for bundling #962

wants to merge 1 commit into from

Conversation

lindskogen
Copy link

@lindskogen lindskogen commented Mar 30, 2021

This is an initial draft for a solution to #953.

esbuild doesn't seem to support UMD builds which could be a dealbreaker.

Also, there's nothing like rollup-plugin-strip-code for esbuild yet.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4a23d3e:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration

@netlify
Copy link

netlify bot commented Mar 30, 2021

Deploy preview for redux-starter-kit-docs ready!

Built with commit 4a23d3e

https://deploy-preview-962--redux-starter-kit-docs.netlify.app

@msutkowski msutkowski linked an issue Mar 30, 2021 that may be closed by this pull request
@markerikson
Copy link
Collaborator

Hey there, thanks for the PR! Appreciate you filing this. Unfortunately, there's actually already an in-progress PR to convert our build system over to ESBuild over in #957 , which is close to complete. I was actually just about to review it again to see if there's anything left to be done.

Given that, I'm afraid this probably needs to be closed. Sorry about that! However, I'd definitely appreciate any help you could offer with some of the other open issues we're tracking for our 1.6 milestone:

https://github.com/reduxjs/redux-toolkit/milestone/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework RTK build tooling for 1.6 release
2 participants