Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for current Observable interpolation interface #3067

Merged
merged 4 commits into from
Mar 19, 2019

Conversation

pinyin
Copy link
Contributor

@pinyin pinyin commented Jul 20, 2018

closes #1723

According to #1725, the issue was closed because TypeScript wasn't supporting symbol-named properties at that time, which in my understanding is no longer the case.

Is it the time to add the types now?

@timdorr
Copy link
Member

timdorr commented Jul 20, 2018

Yep, it's a good time. If anyone else wants to chime in with feedback, feel free. But I think this looks good as-is.

@netlify
Copy link

netlify bot commented Dec 13, 2018

Deploy preview for redux-docs ready!

Built with commit 490c31e

https://deploy-preview-3067--redux-docs.netlify.com

@timdorr
Copy link
Member

timdorr commented Mar 19, 2019

Sorry this took so long, but I think it's OK. Thanks!

@timdorr timdorr merged commit 4fb7a44 into reduxjs:master Mar 19, 2019
kiku-jw pushed a commit to kiku-jw/redux that referenced this pull request Apr 6, 2019
* Add types about Observable interpolation

* Run through Prettier

* Also run through Prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typings for store.observable
2 participants