build: use typescript-eslint@v6 internally #4566
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
commented
Jun 19, 2023
|
|
||
| parser: '@typescript-eslint/parser', | ||
|
|
||
| parserOptions: { | ||
| project: true, |
There was a problem hiding this comment.
project: true is already in typescript-eslint@v5. It's just a nice way to enable parserOptions.project 馃槃
JoshuaKGoldberg
commented
Jun 19, 2023
| '@typescript-eslint/prefer-function-type': 'off', | ||
| '@typescript-eslint/sort-type-constituents': 'off', | ||
| '@typescript-eslint/unbound-method': 'off', | ||
| 'prefer-rest-params': 'off', |
There was a problem hiding this comment.
Each of these had at least a few existing warnings, so I didn't want to overreach and solve for them without asking. Are any of these rules ones you feel particularly strongly about?
- https://typescript-eslint.io/rules/ban-ts-comment
- https://typescript-eslint.io/rules/ban-types
- https://typescript-eslint.io/rules/consistent-indexed-object-style
- https://typescript-eslint.io/rules/consistent-type-definitions
- https://typescript-eslint.io/rules/no-confusing-void-expression
- https://typescript-eslint.io/rules/no-empty-function
- https://typescript-eslint.io/rules/no-floating-promises
- https://typescript-eslint.io/rules/no-unsafe-argument
- https://typescript-eslint.io/rules/no-unsafe-assignment
- https://typescript-eslint.io/rules/no-unsafe-call
- https://typescript-eslint.io/rules/no-unsafe-member-access
- https://typescript-eslint.io/rules/no-unsafe-return
- https://typescript-eslint.io/rules/prefer-function-type
- https://typescript-eslint.io/rules/sort-type-constituents
- https://typescript-eslint.io/rules/unbound-method
- https://eslint.org/docs/latest/rules/prefer-rest-params
If not, I can go ahead and fix for all their complaints.
JoshuaKGoldberg
commented
Jun 19, 2023
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8a167d5:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Does this PR add a new feature, or fix a bug?
Internal tooling. 馃槃
Why should this PR be included?
Checklist
New Features
Upgraded typescript-eslint to v6, with reworked ESLint configurations.
You can read https://typescript-eslint.io/blog/announcing-typescript-eslint-v6-beta#user-facing-breaking-changes for the rationale behind the config changes. Essentially, the new recommended starter configs are:
"plugin:@typescript-eslint/recommended-type-checked""plugin:@typescript-eslint/stylistic-type-checked"I've commented any changes ripe for discussion internally. This one was pretty straightforward compared to others though.