Fix: use unique value for NOT_FOUND #709
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what's the reasoning for using a string constant for the not-found value, but an object feels both safer (real uniqueness, the string
'NOT_FOUND'
could make the logic fail) and more performant (nostrcmp()
if both values are strings) which is handy when the selectors are called very often.I've used a private class instance for the empty value because you seem to use the value type
NOT_FOUND_TYPE
, otherwise I would have gone with aSymbol('not-found')
or an empty object, but any of these would be fine I think.