Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rsc): update paths and CI #10196

Merged
merged 1 commit into from
Mar 11, 2024
Merged

chore(rsc): update paths and CI #10196

merged 1 commit into from
Mar 11, 2024

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Mar 11, 2024

This PR extracts out the non Vite v5 related changes from #10167. That one is proving difficult (the SSR smoke test keeps failing—entry.server.mjs isn't in dist, but entry.client.mjs is 🤔) and I don't want some of these changes to have to wait since they're unrelated.

@jtoar jtoar added release:chore This PR is a chore (means nothing for users) changesets-ok Override the changesets check labels Mar 11, 2024
@jtoar jtoar added this to the RSC milestone Mar 11, 2024
@jtoar jtoar marked this pull request as ready for review March 11, 2024 14:16
@jtoar jtoar merged commit 90b8479 into main Mar 11, 2024
41 checks passed
@jtoar jtoar deleted the ds-rsc/update-paths-and-ci branch March 11, 2024 14:17
@jtoar jtoar mentioned this pull request Mar 11, 2024
Merged
jtoar added a commit that referenced this pull request Mar 11, 2024
@jtoar
feat(vite): upgrade to v5 (#10197)
4fd86e8 
Redoing #10167 since I've split
out some of the changes in
#10196 and want a cleaner
commit history to debug CI.
jtoar added a commit that referenced this pull request Mar 12, 2024
@jtoar
feat(vite): upgrade to v5 (#10197)
e11d73e 
Redoing #10167 since I've split
out some of the changes in
#10196 and want a cleaner
commit history to debug CI.
@Tobbe Tobbe mentioned this pull request Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Milestone
RSC
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jtoar