New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try fixing e2e network flakiness #4082
Conversation
@jtoar This is definitely interesting, especially given that 1) we've had external networking issues in the past (npm package installation) and 2) we don't have any visibility/control over how the services/containers are networked within the workflow, which could definitely be causing issues given that we spin up processes outside of other services. Let's give it a shot! Research link:
Looks like we'll need to run some tests regarding
Not sure if we can assume unique name is same each time without further research. Will need to run |
- name: Tune linux network | ||
run: sudo ethtool -K eth0 tx off rx off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this works, we should add to add workflows, setting a condition to run in case of Linux only.
Ok! I'll merge and rebase some of the existing PRs that are failing to see if this needs any more of the tweaks you mentioned. |
@thedavidprice Here's the output of Maybe we need to tune # For network flakiness. See https://github.com/vercel/next.js/pull/28264
- name: Tune linux networks
run: |
sudo ethtool -K eth0 tx off rx off
+ sudo ethtool -K docker0 tx off rx off |
This is an attempt to fix network flakiness using the strategy in vercel/next.js#28264. I tried this out on my fork of redwood and it seemed to actually work (PR here: https://github.com/jtoar/redwood/pull/155), but I have no idea what this really does. (The original comment says that it "disables TCP/UCP offloading", but I don't really know what that entails.)