chore: clean up mock auth client #5911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for redwoodjs-docs canceled.
|
virtuoushub
force-pushed
the
fix/auth/update-mock-client
branch
from
b627ac7
to
9fd55e7
Compare
virtuoushub
commented
Jul 18, 2022
| @@ -20,6 +21,7 @@ const { | |||
| default: UserRouterWithRoutes, | |||
| } = require('~__REDWOOD__USER_ROUTES_FOR_MOCK') | |||
|
|
|||
| // TODO: make this AuthContextInterface & the below AuthClient more composable/extendable|"overwriteable" | |||
There was a problem hiding this comment.
this TODO is more of a nice to have, doesn't need to happen in this PR (also might change somewhat depending on auth changes in PRs like #5985 )
add `forgotPassword`, `resetPassword`, and `validateResetToken`. also add better typings and comment to improve this mock provider
virtuoushub
force-pushed
the
fix/auth/update-mock-client
branch
from
9fd55e7
to
e46c447
Compare
Tobbe
approved these changes
Jul 18, 2022
virtuoushub
added a commit
to redwoodjs/example-storybook
that referenced
this pull request
Jul 19, 2022
virtuoushub
added a commit
to redwoodjs/example-storybook
that referenced
this pull request
Jul 19, 2022
virtuoushub
added a commit
to redwoodjs/example-storybook
that referenced
this pull request
Jul 19, 2022
virtuoushub
added a commit
to redwoodjs/example-storybook
that referenced
this pull request
Jul 21, 2022
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Jul 22, 2022
…o feat/ts-strictmode-gen * 'feat/ts-strictmode-gen' of github.com:dac09/redwood: (94 commits) fix(deps): update dependency @graphql-codegen/cli to v2.9.1 (redwoodjs#6013) Little grammar change (redwoodjs#6006) chore: connect repo to nx cloud to speed up builds (redwoodjs#5988) fix(deps): update dependency @testing-library/user-event to v14.3.0 (redwoodjs#6004) fix(deps): update graphqlcodegenerator monorepo (redwoodjs#6005) chore(deps): update dependency @auth0/auth0-spa-js to v1.22.2 (redwoodjs#6003) fix(graphql): Fixes multiValueHeader handling (and CORS) in graphql handler (redwoodjs#5970) chore(deps): update dependency @nhost/hasura-auth-js to v1.4.0 (redwoodjs#6001) chore(deps): update dependency @nhost/nhost-js to v1.4.7 (redwoodjs#5999) fix(deps): update dependency cross-undici-fetch to v0.4.14 (redwoodjs#6000) chore(deps): update dependency @azure/msal-browser to v2.28.0 (redwoodjs#5994) fix(deps): update dependency concurrently to v7.3.0 (redwoodjs#5995) chore(deps): update dependency @simplewebauthn/browser to v5.3.0 (redwoodjs#5989) chore(deps): update dependency @simplewebauthn/server to v5.3.0 (redwoodjs#5990) chore(deps): update dependency @simplewebauthn/typescript-types to v5.3.0 (redwoodjs#5991) fix(deps): update dependency @testing-library/user-event to v14.2.6 (redwoodjs#5992) fix(deps): update typescript-eslint monorepo to v5.30.7 (redwoodjs#5993) chore: clean up mock auth client (redwoodjs#5911) Adds Webauthn support (TouchID, FaceID) to dbAuth (redwoodjs#5680) chore(deps): update dependency octokit to v2.0.4 (redwoodjs#5986) ...
jtoar
pushed a commit
that referenced
this pull request
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forgotPassword,resetPassword, andvalidateResetToken.note: not sure if the
asynckeyword is a 💯 % necessary here (outside of the typings...), and if it will cause issues for downstream users.For context, I found this over at:
stems from this change: redwoodjs/example-storybook@18793b1