Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRWA]: Upgrade from listr to listr2 #6447

Merged
merged 5 commits into from Oct 3, 2022

Conversation

Josh-Walker-GM
Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM commented Sep 25, 2022

Problem
Assuming #6444 is accepted then CRWA uses older listr while the CLI uses the newer listr2. No need to fetch two different packages that do the same thing.

Solution
Update the CRWA to use listr2 in line with the CLI.

Changes
The changes are very minor.

  1. Updated package requirements
  2. Update package imports
  3. Update collapse: false to rendererOptions: {collapse: false}}

Outstanding work
Nothing I can think of right now. There may be in-progress discussions or updates to the CRWA which I'm unaware of. Hopefully none of these invalidate this proposed change.

In principle listr2 supports prompting via the enquirer package and so it might be useful to homogenous prompting across the whole project to use this package rather than the current prompts but this is probably beyond the scope of this small PR.

@jtoar jtoar assigned jtoar and unassigned dthyresson Sep 27, 2022
@jtoar jtoar added topic/cli release:chore This PR is a chore (means nothing for users) release:fix This PR is a fix and removed release:chore This PR is a chore (means nothing for users) labels Sep 27, 2022
@Josh-Walker-GM Josh-Walker-GM marked this pull request as ready for review September 27, 2022 19:48
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Josh-Walker-GM, LGTM!

@jtoar jtoar merged commit eae07ea into redwoodjs:main Oct 3, 2022
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Oct 3, 2022
@jtoar jtoar modified the milestones: next-release, v3.2.0 Oct 5, 2022
@Josh-Walker-GM Josh-Walker-GM deleted the crwapp-listr-to-listr2 branch November 29, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix topic/cli
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants