Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Supabase): Set Supabase webPackage to 1.35.7 #6731

Closed
wants to merge 1 commit into from

Conversation

Alonski
Copy link
Contributor

@Alonski Alonski commented Oct 25, 2022

This should not be merged into main!

A hotfix branch needs to be created off of tag v3.2.0 and a hotfix such as v3.2.1 should be released.

Description

This change hardcodes the version supported for Supabase in the webPackages const for the Supabase provider

The latest Supabase version v2.0.4 is incompatible with the current Supabase auth setup.

For example using their Docs on using Supabase with Redwood: https://supabase.com/docs/guides/with-redwoodjs

The function client.auth.signIn does not exist anymore in v2.0.4

Fix: #6729

This change hardcodes the version supported for Supabase in the webPackages const for the Supabase provider

The latest Supabase version v2.0.4 is incompatible with the current Supabase auth setup.

For example using their Docs on using Supabase with Redwood:
https://supabase.com/docs/guides/with-redwoodjs

The function `client.auth.signIn` does not exist anymore in v2.0.4

Fix: redwoodjs#6729
@jtoar jtoar added this to the next-release-patch milestone Oct 25, 2022
@jtoar
Copy link
Contributor

jtoar commented Oct 25, 2022

Thanks @Alonski! It's actually ok to merge this one into main. The bug is also present there, and we usually cherry pick changes from main into the release branches (which start from the appropriate tag). Mind making your change to this line here?

https://github.com/redwoodjs/redwood/blob/main/packages/auth-providers-setup/src/supabase/setup.ts#L27

(Don't worry, when I cherry pick there'll be a conflict and I'll handle it in the way you've detailed in this PR)

@Alonski
Copy link
Contributor Author

Alonski commented Oct 26, 2022

@jtoar The issue is that the file I am changing doesn't exist anymore in main because of #5985
I will open a new PR for fixing main.

@Alonski
Copy link
Contributor Author

Alonski commented Oct 26, 2022

Opened: #6739

@jtoar
Copy link
Contributor

jtoar commented Oct 26, 2022

@Alonski totally; the way we do things right now is that, if the bug exists in the main branch as well, we fix it there first, then cherry pick the change into the next branch, then cut a release. We have two branches for this next major (v4) because we need time to get the changes to auth right, but want to keep releasing minors and patches in the meantime.

@jtoar jtoar removed this from the next-release-patch milestone Oct 27, 2022
@jtoar
Copy link
Contributor

jtoar commented Oct 27, 2022

Thanks @Alonski, this patch has been in released in https://github.com/redwoodjs/redwood/releases/tag/v3.2.1.

@jtoar jtoar closed this Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: Can't signin with Supabase auth
2 participants