Meta: Fix isMilestone's test url #184
Conversation
index.ts
Outdated
| @@ -149,7 +149,7 @@ addTests('isLabelList', [ | |||
|
|
|||
| export const isMilestone = (url: URL | HTMLAnchorElement | Location = location): boolean => /^milestone\/\d+/.test(getRepo(url)?.path!); | |||
| addTests('isMilestone', [ | |||
| 'https://github.com/sindresorhus/refined-github/milestone/12', | |||
| 'https://github.com/sindresorhus/refined-github/milestones/12', | |||
There was a problem hiding this comment.
milestone is right, you can see: https://github.com/kubernetes/kubernetes/milestone/56
There was a problem hiding this comment.
@kang8 Oops, I thought issue page with milestone filter is milestones page.
I'll change this url as you suggenstioned. Thank you!
There was a problem hiding this comment.
You can check the url on example is 404 page.
https://github.com/refined-github/refined-github/milestone/12
There was a problem hiding this comment.
Out of conversation, why GH is using resources path messy?
for example, issue's path is (issues) refined-github/refined-github#6000 but pr is (pull) refined-github/refined-github#100
There was a problem hiding this comment.
why GH is using resources path messy?
Consistency is hard on large projects 😃
|
Note that these URLs are not expected to exist so I'm sure there are dozens of such examples, it's not worth fixing them unless we're updating a detection |
|
Aha... |
Indeed, that's why we've been adding "Test URLs" at the bottom of each feature. For older features you might find the test URLs in their old PRs. |
No description provided.