Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid adding real names when the user is using a real name #2165

Closed
fregante opened this issue Jun 22, 2019 · 4 comments · Fixed by #2193
Closed

Avoid adding real names when the user is using a real name #2165

fregante opened this issue Jun 22, 2019 · 4 comments · Fixed by #2193
Labels
enhancement help wanted small Issues that new contributors can pick up

Comments

@fregante
Copy link
Member

fregante commented Jun 22, 2019

This isn't useful:

I'd rather see this:


Feature: show-names

If name matches username
	replace username with name (to keep capitalization)
  • Either we drop the space altogether (so in this case there won't be any changes for these users, but there would be for sindresorhus, which would become SindreSorhus), or
  • we replace it with <span style="margin-left:0.2em"/> so it won't break copy-pasting.

Example URL:
microsoft/TypeScript#30442 (reference)

@fregante fregante added enhancement under discussion small Issues that new contributors can pick up help wanted and removed under discussion labels Jun 22, 2019
@notlmn
Copy link
Contributor

notlmn commented Jun 22, 2019

Wouldn't this break #2146, in a way 🤷‍♂️.

@sindresorhus
Copy link
Member

Sounds good, but there should be a space visually, I don't want to see SindreSorhus.

@fregante
Copy link
Member Author

fregante commented Jun 22, 2019

Wouldn't this break #2146

As far as textContent is concerned, only the case will change. sindresorhus -> SindreSorhus so to fix that feature we just need a .toLowercase() in a couple of places.


To make it even safer if could use

<u>s</u>indre<s/><u>s</u>orhus

where s and u are margin-left: 0.2em and text-transform: uppercase respectively.

.textContent would be completely unchanged for all extensions, however it's probably a pain to code that.


Or use .pathname to get the user name instead of .textContent

@fregante
Copy link
Member Author

One more: Punctuation.

punctuation

fregante/webext-options-sync#13 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted small Issues that new contributors can pick up
Development

Successfully merging a pull request may close this issue.

3 participants