Replace username with realname if they’re the same: show-names
#2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
reviewed
Jun 29, 2019
It might be worth looking for other places that would break because of this. TS note: the code would be |
jerone
reviewed
Jun 29, 2019
|
I would check for the following:
|
|
(tested #2185) |
|
Can you pick this up again before #2229? |
|
Oops, didn't notice you fixed this a while ago. Tested and it works great both in discussions and newsfeed.
|
fregante
added a commit
to notlmn/refined-github
that referenced
this pull request
Aug 1, 2019
Following refined-github#2193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2165
Before
After
Test
microsoft/TypeScript#30442 (reference)
fregante/webext-options-sync#13 (comment)
Requires #2146 to use
select<HTMLAnchorElement>('.author')!.pathname.slice(1)