Added missing explicit return types and turned eslint rule back on #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickytonline
force-pushed
the
remove-unused-eslint-rule
branch
from
521d104
to
78ca388
Compare
fregante
requested changes
Apr 19, 2019
Co-Authored-By: nickytonline <nick@iamdeveloper.com>
fregante
reviewed
Apr 19, 2019
fregante
force-pushed
the
remove-unused-eslint-rule
branch
from
9a527df
to
1024b04
Compare
fregante
force-pushed
the
remove-unused-eslint-rule
branch
from
1024b04
to
616826f
Compare
nickytonline
force-pushed
the
remove-unused-eslint-rule
branch
from
90ba778
to
bf7aad5
Compare
nickytonline
force-pushed
the
remove-unused-eslint-rule
branch
from
bf7aad5
to
6bbcd70
Compare
nickytonline
commented
Apr 21, 2019
nickytonline
commented
Apr 21, 2019
nickytonline
commented
Apr 21, 2019
nickytonline
commented
Apr 21, 2019
|
Now that the cache is generic, I think this is good to go. Let me know your thoughts on the cache changes @bfred-it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here you go @bfred-it. This fixes missing explicit return types as per @sindresorhus comment, #1740 (comment)