Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Restore stylelint on all files, cross-platform #2687

Merged
merged 5 commits into from
Jan 11, 2020

Conversation

jerone
Copy link
Contributor

@jerone jerone commented Jan 11, 2020

See discussion here. Stylelint was not running correctly on any other OS then Windows with the glob value.

This PR fixes:

  1. the glob issue. See proof here: https://github.com/sindresorhus/refined-github/pull/2687/checks?check_run_id=384780372#step:4:9. I couldn't use single quotes ', because that resulted in Error: No files matching the pattern "'source/**/*.css'" were found.. Using double quotes fixed that.
  2. fixes the errors from stylelint.

source/options.css Outdated Show resolved Hide resolved
@fregante fregante added the meta Related to Refined GitHub itself label Jan 11, 2020
@fregante fregante changed the title Fix running stylelint with globs Meta: Restore stylelint on all files, cross-platform Jan 11, 2020
@fregante fregante merged commit c14e188 into refined-github:master Jan 11, 2020
@fregante
Copy link
Member

🎉

@jerone
Copy link
Contributor Author

jerone commented Jan 11, 2020

@fregante Your last commit blocks Windows! See my description above:

I couldn't use single quotes ', because that resulted in Error: No files matching the pattern "'source/**/*.css'" were found.. Using double quotes fixed that.

@jerone
Copy link
Contributor Author

jerone commented Jan 11, 2020

@fregante Your last commit blocks Windows! See my description above:

I couldn't use single quotes ', because that resulted in Error: No files matching the pattern "'source/**/*.css'" were found.. Using double quotes fixed that.

See stylelint/stylelint#3624 and https://github.com/stylelint/stylelint.io/blob/master/package.json#L14

@jerone jerone deleted the fix-stylelint branch January 11, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to Refined GitHub itself
Development

Successfully merging this pull request may close these issues.

None yet

2 participants