Deemphasize update-pr-from-base-branch button

[FloEdelmann]

Closes #2723, closes #3017.

I've taken a little different approach than outlined in #2723: Always add the button as a .btn-link to the .status-meta, and also show .status-meta for success status messages if necessary. That way, we don't have to deal with different locations for the same button.

I hope I have tested all cases, please everyone try this in other PRs with different status messages!

[fregante]

Excellent! However I think this undoes clean-mergeability-box at least partially. Can you just add an extra line and only unhide that (with :not()) rather than the whole line that we normally hide?

[FloEdelmann]

I've put it inside a separate .status-meta, and it even stays on the same line because both are display: inline; 😊

[fregante]

I see it on this PR

but not on #3153:

Is this due to #3155?

[FloEdelmann]

@fregante Probably, since I didn't change the logic when to show the button in this PR, just where and how.

Could you check if the button is maybe added in a hidden section?

In a similar case (OpenLightingProject/open-fixture-library#359: I have write access to the repo, someone else opened a draft PR that is now out-of-date), I see it's added for me (both in the current version and the updated look) when I disable the Require branches to be up to date before merging branch setting.

[fregante]

It doesn't seem related to this PR. The button doesn't appear on master either.

Could you check if the button is maybe added in a hidden section?

It's not. I posted the DOM structure in #3155

I'll test this further and merge it

[fregante]

🙌