Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t run bypass-checks on non "run" actions #3644

Merged
merged 8 commits into from Oct 14, 2020
Merged

Don’t run bypass-checks on non "run" actions #3644

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cc2e364
Don’t run `bypass-checks` on non "run" actions
yakov116 Oct 13, 2020
567b797
Use Regex
yakov116 Oct 13, 2020
da02105
The comment
yakov116 Oct 13, 2020
27d4cd1
Use page detect
yakov116 Oct 13, 2020
ddedf33
update `github-url-detection`
yakov116 Oct 14, 2020
ee763a5
Apply suggestions from code review
yakov116 Oct 14, 2020
6d9ffd3
Revert "update `github-url-detection`"
yakov116 Oct 14, 2020
95a4987
Merge remote-tracking branch 'FloEdelmann/master' into cant_bypass_em…
yakov116 Oct 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion source/features/bypass-checks.tsx
View file
Open in desktop
Expand Up @@ -7,7 +7,13 @@ import * as api from '../github-helpers/api';
import {getRepoURL} from '../github-helpers';

async function bypass(detailsLink: HTMLAnchorElement): Promise<void> {
const runId = new URLSearchParams(detailsLink.search).get('check_run_id') ?? detailsLink.pathname.split('/').pop()!;
const [actionType, splitRunid] = detailsLink.pathname.split('/').splice(-2);
const runId = new URLSearchParams(detailsLink.search).get('check_run_id') ?? splitRunid;

if (!Number.parseInt(runId, 10) || actionType !== 'run') {
fregante marked this conversation as resolved.
Show resolved Hide resolved
return;
yakov116 marked this conversation as resolved.
Show resolved Hide resolved
}

const directLink = await api.v3(`repos/${getRepoURL()}/check-runs/${runId}`);
detailsLink.href = directLink.details_url;
}
Expand Down