Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint #3684

Merged
merged 17 commits into from Oct 26, 2020
Merged

Lint #3684

merged 17 commits into from Oct 26, 2020

Conversation

yakov116
Copy link
Member

@yakov116 yakov116 commented Oct 23, 2020 •
edited

  • Update XO and Regenerate package-lock
  • Enable new XO Rules
  • Make api.v3 default to repos/${getRepoURL}
  • Add getPRRepositoryInfo
  • November Lint
  • Change getRepoURL to use getPRRepositoryInfo

@yakov116
Copy link
Member Author

@fregante did you regenerate the package-lock.json after #3639?

I was having issues so I regenerated.

@yakov116 yakov116 marked this pull request as ready for review October 23, 2020 15:24
@fregante fregante changed the title November lint Lint Oct 23, 2020
@fregante
Copy link
Member

What timezone are you in?

@yakov116
Copy link
Member Author

Eastern

fregante
fregante requested changes Oct 23, 2020
View reviewed changes
source/globals.d.ts Outdated Show resolved Hide resolved
source/globals.d.ts Show resolved Hide resolved
source/github-helpers/parse-backticks.tsx Show resolved Hide resolved
source/github-helpers/api.ts Outdated Show resolved Hide resolved
source/features/index.tsx Outdated Show resolved Hide resolved
source/features/deep-reblame.tsx Show resolved Hide resolved
@fregante fregante added the meta Related to Refined GitHub itself label Oct 23, 2020
fregante
fregante reviewed Oct 25, 2020
View reviewed changes
source/features/index.tsx Outdated Show resolved Hide resolved
fregante
fregante approved these changes Oct 25, 2020
View reviewed changes
Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be merged once the few last few comments I left are resolved

fregante and others added 4 commits October 25, 2020 09:31
@fregante
Update package-lock.json
8deb574 
It was incomplete
@yakov116 @fregante
Update source/github-helpers/api.ts
bcf368b 
Co-authored-by: Federico <me@fregante.com>
@yakov116 @fregante
Update source/features/index.tsx
c33bc2a 
Co-authored-by: Federico <me@fregante.com>
@yakov116
Pass Lint
be5344c
@yakov116 yakov116 merged commit de5c0b4 into refined-github:master Oct 26, 2020
@yakov116 yakov116 deleted the november_lint branch October 26, 2020 12:40
@fregante
Copy link
Member

Likewise, we can change the v4 to automatically inject the current owner/name when it encounters an empty 'repository()' string and we can delete the awkward getRepoGQL function

@yakov116
Copy link
Member Author

Agree but I was not sure how to implement it. Will try on the next round.

@fregante
Copy link
Member

fregante commented Nov 1, 2020 •
edited

I think it'd be something like this in v4():

query = query.replace('repository() {', `repository(owner: ${…} name: ${…}) {`)

@fregante
Copy link
Member

fregante commented Nov 1, 2020

Wait though because #3695 changes the same lines

@yakov116
Copy link
Member Author

yakov116 commented Nov 1, 2020

Its not November yet... (at least in my time zone) 😃

@fregante
Copy link
Member

fregante commented Nov 1, 2020

I'll start adding ideas to "the last lint pr":

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fregante fregante fregante approved these changes

Assignees
No one assigned
Labels
meta Related to Refined GitHub itself
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yakov116 @fregante