Move update-pr-from-base-branch to a more reliable position
#3931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Brilliant! Cleaner Code, Much better. I like the look too! 🎉 |
Or else we keep getting the link, because api.v3 is memoized and the dom is regenerated before the API itself clears its cache.
Yeah most of the code there was duplicate or just no longer working. |
|
Can we do |
|
Good point, I tried shortening it but it's not super clear. I restored the previous text. And… merged just in time! 21.2.1 coming! |
|
|
|
You stopped it? Why did it not run? |
|
It should have, the time was correctly parsed by GitHub too.
I'm guessing:
I'll deploy manually now either way |
|
Oh shoot, just in time.
|
|
Any reason it's still referred to as a |
|
What would you call it? It's not a link, it doesn't link to anything. Maybe the text can be changed to something like "Lets you update the PR with a click" without using "Adds a XXX" every time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3927
Fixes #3699
Replaces #3929
I noticed that the mergeability box varies a lot and it's a pain to cover all the cases reliably. So I just moved the action next to the text that tells we can update it by pushing, which makes sense. Also it helps that this text doesn't change that often.
The only drawback is that it wraps more often than it did before, pushing the box lower by 20px.
cc @yakov116