Lint #6326
Merged
Lint #6326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
commented
Feb 10, 2023
| @@ -71,7 +71,7 @@ function linkBestComment(bestComment: HTMLElement): void { | |||
| } | |||
|
|
|||
| const text = select('.comment-body', bestComment)!.textContent!.slice(0, 100); | |||
| const {hash} = select<HTMLAnchorElement>('a.js-timestamp', bestComment)!; // TODO: Drop generic once TypeScript sorts it out, it shouldn't be needed | |||
| const {hash} = select('a.js-timestamp', bestComment)!; | |||
fregante
commented
Feb 11, 2023
| {forEach: linkify}, | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
Change tested, it works
fregante
commented
Feb 11, 2023
| append: createReviewLink, | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
Change tested, it works
fregante
commented
Feb 11, 2023
| ): NodeListOf<ParseSelector<S, HTMLElement>>; | ||
| } | ||
|
|
||
| interface Element { | ||
| closest<S extends string>(selector: S): ParseSelector<S, HTMLElement> | null; | ||
| closest<S extends string>(selector: S | readonly S[]): ParseSelector<S, HTMLElement> | null; | ||
| matches(selectors: string | readonly string[]): boolean; |
There was a problem hiding this comment.
readonly allows passing arrays like ['input', 'textarea'] as const, which are tighter than string[]
fregante
commented
Feb 11, 2023
| @@ -42,7 +42,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@cheap-glitch/mi-cron": "^1.0.1", | |||
| "@primer/octicons-react": "^17.5.0", | |||
| "@primer/octicons-react": "^17.11.1", | |||
There was a problem hiding this comment.
I had to undo this because dom-chef started failing 馃ゲ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃槑