-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta: Update old screenshots #6830
Merged
fregante
merged 90 commits into
refined-github:main
from
DanielMiao1:update-screenshots
Aug 27, 2023
Merged
Meta: Update old screenshots #6830
fregante
merged 90 commits into
refined-github:main
from
DanielMiao1:update-screenshots
Aug 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking great so far! Generally avoid force-pushes after a review because it makes it difficult to track what changed |
Unfortunately, the `type` dropdown near the search bar no longer shows the selected type when the dropdown is closed, making it more difficult to understand the changes RGH has made to the page when the dropdown is closed in the new UI. This commit separates the screenshot in the feature description to two screenshots to highlight the two features described in the description independently using a before/after image for showing the hidden archived repos, while demonstrating the ability to show the hidden entries using an arrow-pointing-to-button image.
…ation/should be fixed
fregante
reviewed
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all the changes, looks good so far except these two
fregante
reviewed
Aug 25, 2023
Co-authored-by: Federico Brigante <me@fregante.com>
Co-authored-by: Federico Brigante <me@fregante.com>
Applies refined-github#6830 (review) with changes
fregante
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates most outdated screenshots and GIFs in readme.md
(originally suggested in 6000 (comment))