Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Update old screenshots #6830

Merged
merged 90 commits into from
Aug 27, 2023

Conversation

DanielMiao1
Copy link
Contributor

Updates most outdated screenshots and GIFs in readme.md

(originally suggested in 6000 (comment))

@fregante
Copy link
Member

Looking great so far!

Generally avoid force-pushes after a review because it makes it difficult to track what changed

Unfortunately, the `type` dropdown near the search bar no longer shows the selected type when the dropdown is closed, making it more difficult to understand the changes RGH has made to the page when the dropdown is closed in the new UI. 

This commit separates the screenshot in the feature description to two screenshots to highlight the two features described in the description independently using a before/after image for showing the hidden archived repos, while demonstrating the ability to show the hidden entries using an arrow-pointing-to-button image.
Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all the changes, looks good so far except these two

readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@DanielMiao1 DanielMiao1 marked this pull request as ready for review August 26, 2023 16:06
@fregante fregante merged commit e83de1c into refined-github:main Aug 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to Refined GitHub itself
Development

Successfully merging this pull request may close these issues.

None yet

2 participants