-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta: Simplify GitHubFileURL #6870
Conversation
I would like to test this, I will try to get to my computer tonight |
@yakov116 ping |
Sorry i will try to do it in a few hours |
Looks like i will not have time, sorry |
I ended up testing it myself and… in Firefox it fails silently. 🤷♂️ Repro:
|
Can we make some CI tests with puppeteer-like testing framework? |
Oof, good luck. Loading extensions in those environments is a pain, especially so in Firefox. Then nobody will add tests. 😅 |
🥲🥲 Also, It'll be annoying when CI test ran on PR of A feature changes, but failing with B feature. |
Context:
action-pr-link
to links in PRs #6797 (comment)cc @134130