Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Simplify GitHubFileURL #6870

Closed
wants to merge 7 commits into from
Closed

Meta: Simplify GitHubFileURL #6870

wants to merge 7 commits into from

Conversation

fregante
Copy link
Member

@fregante fregante commented Sep 3, 2023

@fregante fregante added the meta Related to Refined GitHub itself label Sep 3, 2023
@yakov116
Copy link
Member

yakov116 commented Sep 3, 2023

I would like to test this, I will try to get to my computer tonight

@fregante
Copy link
Member Author

@yakov116 ping

@yakov116
Copy link
Member

Sorry i will try to do it in a few hours

@yakov116
Copy link
Member

Looks like i will not have time, sorry

@fregante
Copy link
Member Author

I ended up testing it myself and… in Firefox it fails silently. 🤷‍♂️

Repro:

  1. Open https://github.com/refined-github/refined-github/tree/async-detections
  2. Look at default-branch-button, the URL is incorrect
Screenshot 2

@134130
Copy link
Contributor

134130 commented Sep 19, 2023

Can we make some CI tests with puppeteer-like testing framework?
Enable all features, visit all given test urls, make sure there is no failed rgh-features.

@fregante
Copy link
Member Author

Oof, good luck. Loading extensions in those environments is a pain, especially so in Firefox. Then nobody will add tests. 😅

@134130
Copy link
Contributor

134130 commented Sep 19, 2023

🥲🥲 Also, It'll be annoying when CI test ran on PR of A feature changes, but failing with B feature.
It breaks the pull request order and requires consideration of the merge queue.
🤯😟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to Refined GitHub itself
Development

Successfully merging this pull request may close these issues.

None yet

3 participants