-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target macOS 13, iOS 16, Safari 16.4 #6874
Conversation
4f863f3
to
e0d4a93
Compare
The window is currently resizable on macOS. We need to target macOS 13 to be able to lock the window size. |
If you drag the assets folder into the resources window it will add just the folder, not its contents |
e0d4a93
to
7b6be0e
Compare
7b6be0e
to
1c29b36
Compare
That did it 👍 |
I assume because of the new target iOS version, this is now required: fa99606 It works after adding that. |
@fregante This is now done. |
This reverts commit fa99606.
These things require macOS 13. I'm too lazy to polyfill when we can target macOS 13 in a month. I don't think this should hold back merging. |
I think this is reason enough to just target macOS 13 now. |
Sizing a window requires macOS 13?? What APIs are you using? |
That was the idea since Sonoma will be released in like 3 weeks. Those changes can be made here and then it can be merged in a month |
I don't see why it needs to stay open. I don't like long-running PRs, and I also don't plan to do a new Safari version until then anyways (I will be too busy preparing my apps for iOS 17 and macOS 14). |
It's complicated. The window used to always be fixed size if you set a fixed size on the root view, but they changed it in macOS 13 to not respect the root view, but the modifiers to change it back require macOS 13. |
I mean, I did mention that there was no rush and that we could wait until Sonoma, but you can merge anytime. |
Hehe. I know, but today was the time I had time and motivation. |
57e57bb
to
07b16ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Includes #6000 (comment) Safari 16.4+ |
I have recreated the Xcode project from scratch, which massively simplifies the container app. It's now just a single SwiftUI app for both macOS and iOS.