Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target macOS 13, iOS 16, Safari 16.4 #6874

Merged
merged 7 commits into from
Sep 4, 2023
Merged

Target macOS 13, iOS 16, Safari 16.4 #6874

merged 7 commits into from
Sep 4, 2023

Conversation

sindresorhus
Copy link
Member

I have recreated the Xcode project from scratch, which massively simplifies the container app. It's now just a single SwiftUI app for both macOS and iOS.

@sindresorhus
Copy link
Member Author

@fregante Do you remember how you managed to include the "assets" thing in #6612? That's the only thing left. Maybe you could do it again.

@sindresorhus
Copy link
Member Author

The window is currently resizable on macOS. We need to target macOS 13 to be able to lock the window size.

@fregante
Copy link
Member

fregante commented Sep 3, 2023

If you drag the assets folder into the resources window it will add just the folder, not its contents

@sindresorhus
Copy link
Member Author

That did it 👍

@sindresorhus
Copy link
Member Author

I assume because of the new target iOS version, this is now required: fa99606

Screenshot 2023-09-03 at 19 06 27

It works after adding that.

@sindresorhus
Copy link
Member Author

@fregante This is now done.

source/manifest.json Outdated Show resolved Hide resolved
@fregante
Copy link
Member

fregante commented Sep 3, 2023

A couple of issues:

  • the app doesn't quit when the window is closed
  • the app starts with a wide window (the size is remembered across launches)
Screenshot 5

@sindresorhus
Copy link
Member Author

These things require macOS 13. I'm too lazy to polyfill when we can target macOS 13 in a month. I don't think this should hold back merging.

@sindresorhus
Copy link
Member Author

I think this is reason enough to just target macOS 13 now.

@fregante
Copy link
Member

fregante commented Sep 3, 2023

These things require macOS 13

Sizing a window requires macOS 13?? What APIs are you using?

@fregante
Copy link
Member

fregante commented Sep 3, 2023

I think this is reason enough to just target macOS 13 now.

That was the idea since Sonoma will be released in like 3 weeks. Those changes can be made here and then it can be merged in a month

@sindresorhus
Copy link
Member Author

sindresorhus commented Sep 3, 2023

I don't see why it needs to stay open. I don't like long-running PRs, and I also don't plan to do a new Safari version until then anyways (I will be too busy preparing my apps for iOS 17 and macOS 14).

@sindresorhus
Copy link
Member Author

Sizing a window requires macOS 13?? What APIs are you using?

It's complicated. The window used to always be fixed size if you set a fixed size on the root view, but they changed it in macOS 13 to not respect the root view, but the modifiers to change it back require macOS 13.

@sindresorhus sindresorhus changed the title Target macOS 12 and iOS 15 Target macOS 13 and iOS 16 Sep 3, 2023
@fregante
Copy link
Member

fregante commented Sep 3, 2023

I don't like long-running PRs

I mean, I did mention that there was no rush and that we could wait until Sonoma, but you can merge anytime.

@sindresorhus
Copy link
Member Author

I mean, I did mention that there was no rush and that we could wait until Sonoma, but you can merge anytime.

Hehe. I know, but today was the time I had time and motivation.

Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:ship-it:

@fregante fregante added meta Related to Refined GitHub itself and removed meta Related to Refined GitHub itself labels Sep 4, 2023
@fregante
Copy link
Member

fregante commented Sep 4, 2023

Includes #6000 (comment)

Safari 16.4+

@fregante fregante changed the title Target macOS 13 and iOS 16 Target macOS 13, iOS 16, Safari 16.4 Sep 4, 2023
@sindresorhus sindresorhus merged commit 8020f7a into main Sep 4, 2023
11 checks passed
@sindresorhus sindresorhus deleted the safari16 branch September 4, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants