Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-no-pr-search - New feature #7124

Merged
merged 18 commits into from
Dec 2, 2023
Merged

fix-no-pr-search - New feature #7124

merged 18 commits into from
Dec 2, 2023

Conversation

cheap-glitch
Copy link
Member

source/features/redirect-to-issue-list.tsx Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@cheap-glitch cheap-glitch marked this pull request as ready for review November 29, 2023 11:53
readme.md Outdated Show resolved Hide resolved
source/features/redirect-to-issue-list.tsx Outdated Show resolved Hide resolved
source/features/redirect-to-issue-list.tsx Outdated Show resolved Hide resolved
event.preventDefault();

const form = event.delegateTarget;
const searchInput = form.elements['js-issues-search'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💙

source/features/redirect-to-issue-list.tsx Outdated Show resolved Hide resolved
@fregante fregante changed the title Add redirect-to-issue-list feature fix-no-pr-search - New feature Dec 1, 2023
Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than this

source/features/fix-no-pr-search.tsx Outdated Show resolved Hide resolved
source/features/fix-no-pr-search.tsx Outdated Show resolved Hide resolved
cheap-glitch and others added 3 commits December 2, 2023 14:02
Co-authored-by: Federico Brigante <me@fregante.com>
Co-authored-by: Federico Brigante <me@fregante.com>
Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️⭐️⭐️⭐️⭐️ Works as intended. Would approve again

@fregante fregante merged commit 02aef4c into main Dec 2, 2023
10 checks passed
@fregante fregante deleted the add-redirect-to-issues branch December 2, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Automatically redirect pull requests search without "is:pr" to issues
3 participants