Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated in/readme.md with current readme #3333

Merged
merged 3 commits into from
May 30, 2024

Conversation

sagarhedaoo
Copy link
Contributor

All Submissions:

  • [Yes ] Have you followed the guidelines stated in CONTRIBUTING.md file?
  • [Yes ] Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

New Feature Submission:

  • [Yes ] Does your submission pass the tests?
  • [Yes ] Have you linted your code locally prior to submission?

Changes To Core Features:

  • [Yes ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [N/A ] Have you written new tests for your core changes, as applicable?
  • [Yes ] Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

b. Describe your changes.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

@sagarhedaoo sagarhedaoo changed the title Updated in/readme.md with current readme Updated in/readme.md with current readme closes #3315 May 18, 2024
@sagarhedaoo
Copy link
Contributor Author

closes #3315

@sagarhedaoo sagarhedaoo changed the title Updated in/readme.md with current readme closes #3315 Updated in/readme.md with current readme May 18, 2024
Copy link
Collaborator

@Lendemor Lendemor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for helping.

I think for the code you've used the version prior to latest (just before some of the code change in the example)

docs/in/README.md Outdated Show resolved Hide resolved
@sagarhedaoo sagarhedaoo requested a review from Lendemor May 29, 2024 21:19
@picklelo picklelo merged commit 7f054fd into reflex-dev:main May 30, 2024
2 checks passed
@picklelo picklelo mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants