Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] How are we supposed to known the version since 0.4.7? #383

Closed
rgl opened this issue Mar 6, 2023 · 3 comments · Fixed by #392
Closed

[Question] How are we supposed to known the version since 0.4.7? #383

rgl opened this issue Mar 6, 2023 · 3 comments · Fixed by #392
Assignees
Labels
question Further information is requested

Comments

@rgl
Copy link

rgl commented Mar 6, 2023

Question

Since v0.4.7/#304/#305 the tag/version was removed from the regctl version output and replaced with the git revision, e.g.:

VCSRef:     f43ada160d953317c51e7d9170afa2a316f4b9be
VCSCommit:  f43ada160d953317c51e7d9170afa2a316f4b9be

But, how, as a user, am I supposed to quickly known the version?

Version

VCSRef:     f43ada160d953317c51e7d9170afa2a316f4b9be
VCSCommit:  f43ada160d953317c51e7d9170afa2a316f4b9be
VCSState:   clean
VCSDate:    2023-02-26T02:43:41Z
Platform:   linux/amd64
GoVer:      go1.20.1
GoCompiler: gc
@rgl rgl added the question Further information is requested label Mar 6, 2023
@sudo-bmitch
Copy link
Contributor

Right now I don't have a good solution for this without comparing the commit hash to the tags in the git repo:

$ git show f43ada160d953317c51e7d9170afa2a316f4b9be
commit f43ada160d953317c51e7d9170afa2a316f4b9be (tag: v0.4.7, upstream/releases/0.4, releases/0.4)
Author: Brandon Mitchell <git@bmitch.net>
Date:   Sat Feb 25 21:37:17 2023 -0500

    Release v0.4.7
    
    Signed-off-by: Brandon Mitchell <git@bmitch.net>

...

We're currently waiting on a solution from golang/go#50603. If it looks like this won't ever be fixed upstream, then it's possible to go back to injecting tag details with compiler flags.

@rgl
Copy link
Author

rgl commented Mar 7, 2023

I would revert this change until a solution exists.

@mwgamble
Copy link

mwgamble commented Mar 7, 2023

I agree with @rgl, I don't think it's a good idea to wait on something that may never come. It's a perfectly reasonable expectation to be able to run the-program --version and get the actual version number of the software.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants