Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tag in the version output #392

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

sudo-bmitch
Copy link
Contributor

Fixes issue

Fixes #383 #386

Describe the change

This manually injects the git tag into builds when available.

How to verify it

regctl version will output a tag on the next tagged release. Until this, it will indicate (devel) for an untagged release.

Changelog text

Include tag in the version output

Please verify and check that the pull request fulfills the following requirements

  • Tests have been added or not applicable
  • Documentation has been added, updated, or not applicable
  • Changes have been rebased to main
  • Multiple commits to the same code have been squashed

Signed-off-by: Brandon Mitchell <git@bmitch.net>
@sudo-bmitch sudo-bmitch merged commit 3ef593c into regclient:main Mar 20, 2023
@sudo-bmitch sudo-bmitch deleted the pr-build-version branch March 20, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] How are we supposed to known the version since 0.4.7?
1 participant