Feat: fixTableCellAlign option

[jorroll]

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)
• If applicable, I’ve added docs and tests

Description of changes

Adds a new plugin option, mapDepricatedTableCellAttrsToInlineCssfixTableCellAlign, which controls whether table-related attributes are mapped to inline CSS styles. Defaults to true.

Closes #47

Notes:

1. I created this using Github's online vscode editor (i.e. press . when viewing a repo) so I'm not sure if this conforms to any required lint/formatting rules.
2. My own preference is to default to clear, verbose names, but I won't be offended if you'd prefer to rename this option to something else.

[jorroll]

Looks like a ts-ignore which I removed was necessary after all. I'll fix and add some tests...

[codecov-commenter]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (497de53) 100.00% compared to head (e7e99bb) 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@            Coverage Diff            @@
##              main       #48   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          117       129   +12     
=========================================
+ Hits           117       129   +12     

Impacted Files	Coverage Δ
lib/index.js	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[jorroll]

Ready for review

[wooorm]

Thanks! Mostly some stylistic suggestion, otherwise looks good!

[wooorm]

Some recommendations:

Suggested change

	* Default: true. Map deprecated table-related attributes to css styles as
	* recommended by Mozilla Developer Network docs. E.g.
	* `align="center"` to `style="text-align: center;"`. May result
	* in rendering differences.
	* Fix obsolete align attributes on table cells by turning them into inline
	* styles.
	* Keep it on when working with markdown, turn it off when working with
	* markup for emails.

Feel free to iterate on this.

• Uses semantic line breaks
• default: true is already added with the [xxx=true] notation
• the goal of this feature is to solve obsolete attributes, not just because MDN says it too
• adds a recommendation on when to have it on/off

[jorroll]

I accepted this change with the exception that I kept the Default: true comment at the end. When typescript processes this comment and creates the SharedOptions interface, it keeps the JSDoc comments but doesn't keep any reference to [fixTableCellAlign=true] (so, when inspecting the type in the editor, you don't know that it has a default value). By also referencing the default value in the comment, we ensure that the generated type retains this information.

For example, here's what I see when I inspect the prefix option in VS Code. There is no reference to a default value in the editor tooltip and there also isn't a reference to it in the generated typescript type.

[wooorm]

I feel like this is a TypeScript bug.
As you show, it’s also in all the other options here.
And in all the other projects.

It doesn’t hurt too much to include this information if TypeScript doesn’t but then it should be a sentence, and also use `code`.

[wooorm]

I feel like this is a TypeScript bug.
As you show, it’s also in all the other options here.
And in all the other projects.

It doesn’t hurt too much to include this information if TypeScript doesn’t but then it should be a sentence, and also use `code`.

[wooorm]

Thanks, released in 7.2.0!