New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional support for custom options.slugger
#18
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 37 65 +28
=========================================
+ Hits 37 65 +28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Eh, I’ll close this. Again: thanks but no thanks. |
This comment has been minimized.
This comment has been minimized.
FIgured the code would likely be helpeful for others even though your earlier comment appears dismissive and against the intent of most open source projects (and your own code of conduct) |
@RichardLitt and/or Olivia Hugger I'd love to chat any time offline on the interaction in the community here. |
Sure, @agrohs. My email is not hard to find (see my profile). Apologies for not understanding your LinkedIn connection until now - feel free to drop me a line. |
Will do, thanks @RichardLitt - I'll shoot you an email direct! |
No rush! I am offline for a bit, if it takes a minute for me to respond.
…On Saturday, March 11, 2023, Adam Grohs ***@***.***> wrote:
Will do, thanks @RichardLitt <https://github.com/RichardLitt> - I'll
shoot you an email direct!
—
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG6LIIDCE2BWNN434LZCATW3TYSTANCNFSM6AAAAAAVXSCASA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Initial checklist
Description of changes
This adds new support for an additonal
option
containing a customslugger
implementation. By default it still uses the "built in" (opinionated)github-slugger
but also supports your own customerslugger
:This could be another popular third party package such as
slugify
and/or your own custom implementation.Ex usage (custom slugger):
Ex usage (making uses of
slugify
):Related to #16
Closes #17