Exception raises in throttle check #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larryb2019
reviewed
Jul 15, 2022
| @@ -21,6 +21,9 @@ def throttled?(job, *args) | |||
|
|
|||
| job.logger.debug { "Throttle: #{method_name} has been exceeded." } | |||
| true | |||
| rescue Exception => e | |||
There was a problem hiding this comment.
should this be StandardError. or does RocketJob raise top level Exception, Reid should probably answer this
There was a problem hiding this comment.
I am doing this as MySQL connection errors do not come under Standard Errors.
| @@ -1,3 +1,3 @@ | |||
| module RocketJob | |||
| VERSION = "6.1.0".freeze | |||
There was a problem hiding this comment.
this changes functionality, i would raise version to 6.2, Reid what do you think?
mekasudheer
changed the title
|
How did running this work out in production, has it resolved the problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception in throttles
If exception raises in throttle checks its adding error logs but not nullifying worker names for Jobs and Slices, due to this reason jobs are becoming jombie jobs.
If exception raises log error and return true which will eventually updates slice and jobs worker names and reque the jobs/slices.
Requeue jobs before removing worker from pool
Every few seconds we run prune to delete dead workers from pool but jobs are still on that worker name. If we requeue jobs
everytime before removing workers from pool, jobs will be queued immediately instead of waiting till server goes down.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.