Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't do network calls when apps are in background #730

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

sdsantos
Copy link
Collaborator

Addresses #724

The other task needed to close this ticket is to have endpoint apps bind and unbind from the Gateway when they are in the foreground/background.

Copy link
Member

@gnarea gnarea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, but just in case let's wait for the endpoint/app changes before merging this.

kodiakhq bot pushed a commit to relaycorp/awala-ping-android that referenced this pull request Feb 22, 2024
Related with relaycorp/relaynet-gateway-android#724

I tested with the version of Gateway on this PR (relaycorp/relaynet-gateway-android#730) and it worked well.
@gnarea gnarea added the automerge Allow kodiak to automerge commit when all checks pass label Feb 22, 2024
@kodiakhq kodiakhq bot merged commit afbadd8 into master Feb 22, 2024
7 checks passed
@kodiakhq kodiakhq bot deleted the stop-ping-on-background branch February 22, 2024 11:09
Copy link

🎉 This PR is included in version 1.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Allow kodiak to automerge commit when all checks pass released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants