Cap evaluated release limit at 1000 (#1085)

release-drafter · Feb 25, 2022 · d8ca1fa · d8ca1fa
1 parent bd3f0d7
commit d8ca1fa
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -129060,17 +129060,28 @@ const sortReleases = (releases) => {
   }
 }
 
+// GitHub API currently returns a 500 HTTP response if you attempt to fetch over 1000 releases.
+const RELEASE_COUNT_LIMIT = 1000
+
 const findReleases = async ({
   context,
   targetCommitish,
   filterByCommitish,
 }) => {
+  let releaseCount = 0
   let releases = await context.octokit.paginate(
     context.octokit.repos.listReleases.endpoint.merge(
       context.repo({
         per_page: 100,
       })
-    )
+    ),
+    (response, done) => {
+      releaseCount += response.data.length
+      if (releaseCount >= RELEASE_COUNT_LIMIT) {
+        done()
+      }
+      return response.data
+    }
   )
 
   log({ context, message: `Found ${releases.length} releases` })

diff --git a/lib/releases.js b/lib/releases.js
@@ -17,17 +17,28 @@ const sortReleases = (releases) => {
   }
 }
 
+// GitHub API currently returns a 500 HTTP response if you attempt to fetch over 1000 releases.
+const RELEASE_COUNT_LIMIT = 1000
+
 const findReleases = async ({
   context,
   targetCommitish,
   filterByCommitish,
 }) => {
+  let releaseCount = 0
   let releases = await context.octokit.paginate(
     context.octokit.repos.listReleases.endpoint.merge(
       context.repo({
         per_page: 100,
       })
-    )
+    ),
+    (response, done) => {
+      releaseCount += response.data.length
+      if (releaseCount >= RELEASE_COUNT_LIMIT) {
+        done()
+      }
+      return response.data
+    }
   )
 
   log({ context, message: `Found ${releases.length} releases` })