Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure deep merge of config #1012

Merged
merged 3 commits into from Jan 15, 2022
Merged

ensure deep merge of config #1012

merged 3 commits into from Jan 15, 2022

Conversation

jetersen
Copy link
Member

fixes #1011

@jetersen
Copy link
Member Author

@nowsprinting seems we forgot the deep merge part in #973 😅

@jetersen jetersen merged commit 65cb871 into release-drafter:master Jan 15, 2022
@jetersen jetersen deleted the fix/deepMerge branch January 15, 2022 20:27
@jetersen jetersen added the type: bug Something isn't working label Jan 15, 2022
@KevinBatdorf
Copy link

Thanks. How can I ensure no one accidentally adds a label that bumps the major version? Would this work as expected?

    major:
        labels:
            - ''
    minor:
        labels:
            - 'minor'
    patch:
        labels:
            - 'patch'
    default: patch

@jetersen
Copy link
Member Author

jetersen commented Jan 15, 2022

This would still work, that was part of the deep merge fix. You can see the default config here: https://github.com/release-drafter/release-drafter/blob/master/lib/default-config.js

    minor:
        labels:
            - 'minor'
    patch:
        labels:
            - 'patch'
    default: patch

in our code once merged with default it will become:

    major:
        labels: []
    minor:
        labels:
            - 'minor'
    patch:
        labels:
            - 'patch'
    default: patch

@nowsprinting
Copy link
Contributor

@jetersen Thanks!
I didn't expect this issue. sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error applying minor version label
3 participants