Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cap evaluated release limit at 1000 #1085

Merged
merged 1 commit into from Feb 25, 2022
Merged

Cap evaluated release limit at 1000 #1085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 12 additions & 1 deletion dist/index.js
View file
Open in desktop
Expand Up @@ -129060,17 +129060,28 @@ const sortReleases = (releases) => {
}
}

// GitHub API currently returns a 500 HTTP response if you attempt to fetch over 1000 releases.
const RELEASE_COUNT_LIMIT = 1000

const findReleases = async ({
context,
targetCommitish,
filterByCommitish,
}) => {
let releaseCount = 0
let releases = await context.octokit.paginate(
context.octokit.repos.listReleases.endpoint.merge(
context.repo({
per_page: 100,
})
)
),
(response, done) => {
releaseCount += response.data.length
if (releaseCount >= RELEASE_COUNT_LIMIT) {
done()
}
return response.data
}
)

log({ context, message: `Found ${releases.length} releases` })
Expand Down
13 changes: 12 additions & 1 deletion lib/releases.js
View file
Open in desktop
Expand Up @@ -17,17 +17,28 @@ const sortReleases = (releases) => {
}
}

// GitHub API currently returns a 500 HTTP response if you attempt to fetch over 1000 releases.
const RELEASE_COUNT_LIMIT = 1000

const findReleases = async ({
context,
targetCommitish,
filterByCommitish,
}) => {
let releaseCount = 0
let releases = await context.octokit.paginate(
context.octokit.repos.listReleases.endpoint.merge(
context.repo({
per_page: 100,
})
)
),
(response, done) => {
releaseCount += response.data.length
if (releaseCount >= RELEASE_COUNT_LIMIT) {
done()
}
return response.data
}
)

log({ context, message: `Found ${releases.length} releases` })
Expand Down