Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message for when config is not found #973

Merged
merged 6 commits into from Dec 13, 2021
Merged

Improve error message for when config is not found #973

merged 6 commits into from Dec 13, 2021

Commits on Nov 6, 2021

  1. Fix compilation error in tests 

    But 2 fail tests in `config.test.js`.
Because there expects the error to be thrown, but the implementation is only output to log.
Probably a late fix for the tests.
    @nowsprinting
    nowsprinting committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    ffc1ef4 View commit details
    Browse the repository at this point in the history

  2. Mod error message when invalid config file 

    I wanted to add a message for when a config file was not found, but it was difficult due to its structure, so I decided not to.
    @nowsprinting
    nowsprinting committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    accc0a4 View commit details
    Browse the repository at this point in the history

  3. Fix node_modules and rebuild

    @nowsprinting
    nowsprinting committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    0f7f25b View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2021

  1. Fix existing tests using spy

    @nowsprinting
    nowsprinting committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    9b118e5 View commit details
    Browse the repository at this point in the history

  2. Add error message when a config file was not found

    @nowsprinting
    nowsprinting committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    d0be86a View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. Fix tests using jest.spyOn

    @nowsprinting
    nowsprinting committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    9c67d5a View commit details
    Browse the repository at this point in the history