Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to using ESM #158

Merged
merged 4 commits into from Oct 15, 2021
Merged

Migrate to using ESM #158

merged 4 commits into from Oct 15, 2021

Commits on Oct 15, 2021

  1. Migrate to using ESM

    @rwjblue
    rwjblue committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    0c97352 View commit details
    Browse the repository at this point in the history

  2. Fix up linting with ESM changes

    @rwjblue
    rwjblue committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    f648a09 View commit details
    Browse the repository at this point in the history

  3. Update linting packages

    @rwjblue
    rwjblue committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    1909f53 View commit details
    Browse the repository at this point in the history

  4. Only run linting on node 14 

    This works around an issue with node/no-missing-import that doesn't
properly see that `node:path` is a valid module on Node 12.x.

They are using `is-core-module` to figure out if it is a module or not,
and it seems that `is-core-module` doesn't differentiate between core
modules that are available for CJS (the `node:` prefixed paths are only
available in 14.18+ and 16+ in CJS files) and those that are available
to ESM.

This is really just a bandaid, the right fix would be to send a PR to
is-core-module to allow it to check CJS vs MJS modules (since they are
actually different).

See mysticatea/eslint-plugin-node#299
    @rwjblue
    rwjblue committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    a8b3cc7 View commit details
    Browse the repository at this point in the history