Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tests for tables #664

Closed
wants to merge 1 commit into from
Closed

update tests for tables #664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/fixtures/runthrough.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ <h2>Tables</h2>



<table><thead><tr><th>Tag</th><th>Use</th></tr></thead><tbody><tr><td>p</td><td>Paragraph</td></tr><tr><td>table</td><td>Table</td></tr><tr><td>em</td><td>Emphasis</td></tr></tbody></table>
<table><thead><tr><th style="text-align:none">Tag</th><th style="text-align:none">Use</th></tr></thead><tbody><tr><td style="text-align:none">p</td><td style="text-align:none">Paragraph</td></tr><tr><td style="text-align:none">table</td><td style="text-align:none">Table</td></tr><tr><td style="text-align:none">em</td><td style="text-align:none">Emphasis</td></tr></tbody></table>
<p>Left/right aligned columns</p>


Expand Down
8 changes: 4 additions & 4 deletions test/test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,7 @@ test('should pass `isHeader: boolean` to `tr`s', () => {
/>
)
const expected =
'<table><thead><tr><th>a</th></tr></thead><tbody><tr><td>b</td></tr><tr><td>c</td></tr></tbody></table>'
'<table><thead><tr><th style="text-align:none">a</th></tr></thead><tbody><tr><td style="text-align:none">b</td></tr><tr><td style="text-align:none">c</td></tr></tbody></table>'
assert.equal(actual, expected)
})

Expand All @@ -613,7 +613,7 @@ test('should pass `isHeader: true` to `th`s, `isHeader: false` to `td`s', () =>
/>
)
const expected =
'<table><thead><tr><th>a</th></tr></thead><tbody><tr><td>b</td></tr><tr><td>c</td></tr></tbody></table>'
'<table><thead><tr><th style="text-align:none">a</th></tr></thead><tbody><tr><td style="text-align:none">b</td></tr><tr><td style="text-align:none">c</td></tr></tbody></table>'
assert.equal(actual, expected)
})

Expand Down Expand Up @@ -825,7 +825,7 @@ test('should render tables', () => {

assert.equal(
asHtml(<Markdown children={input} remarkPlugins={[gfm]} />),
'<p>Languages are fun, right?</p>\n<table><thead><tr><th style="text-align:left">ID</th><th style="text-align:center">English</th><th style="text-align:right">Norwegian</th><th>Italian</th></tr></thead><tbody><tr><td style="text-align:left">1</td><td style="text-align:center">one</td><td style="text-align:right">en</td><td>uno</td></tr><tr><td style="text-align:left">2</td><td style="text-align:center">two</td><td style="text-align:right">to</td><td>due</td></tr><tr><td style="text-align:left">3</td><td style="text-align:center">three</td><td style="text-align:right">tre</td><td>tre</td></tr></tbody></table>'
'<p>Languages are fun, right?</p>\n<table><thead><tr><th style="text-align:left">ID</th><th style="text-align:center">English</th><th style="text-align:right">Norwegian</th><th style="text-align:none">Italian</th></tr></thead><tbody><tr><td style="text-align:left">1</td><td style="text-align:center">one</td><td style="text-align:right">en</td><td style="text-align:none">uno</td></tr><tr><td style="text-align:left">2</td><td style="text-align:center">two</td><td style="text-align:right">to</td><td style="text-align:none">due</td></tr><tr><td style="text-align:left">3</td><td style="text-align:center">three</td><td style="text-align:right">tre</td><td style="text-align:none">tre</td></tr></tbody></table>'
)
})

Expand All @@ -834,7 +834,7 @@ test('should render partial tables', () => {

assert.equal(
asHtml(<Markdown children={input} remarkPlugins={[gfm]} />),
'<p>User is writing a table by hand</p>\n<table><thead><tr><th>Test</th><th>Test</th></tr></thead></table>'
'<p>User is writing a table by hand</p>\n<table><thead><tr><th style="text-align:none">Test</th><th style="text-align:none">Test</th></tr></thead></table>'
)
})

Expand Down