Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in plugins -> remarkPlugins deprecation message #719

Merged
merged 1 commit into from Dec 15, 2022

Conversation

marc2332
Copy link
Contributor

@marc2332 marc2332 commented Dec 14, 2022

Signed-off-by: Marc Espín mespinsanz@gmail.com

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Change the to of the plugins deprecation message. It should be remarkPlugins instead of plugins. It doesn't make sense to migrate from plugins to plugins.

This is the message that I got:

image

Signed-off-by: Marc Espín <mespinsanz@gmail.com>
@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Dec 14, 2022
@github-actions

This comment has been minimized.

@codecov-commenter

This comment was marked as resolved.

@marc2332
Copy link
Contributor Author

Hi! It seems you removed the template which we require. Here are our templates (pick the one you want to use and click raw to see its source):

* [`pull-request-template.md`](https://github.com/remarkjs/.github/blob/main/.github/pull-request-template.md)

I won’t send you any further notifications about this, but I’ll keep on updating this comment, and hide it when done!

Thanks, — bb

Not sure what the bot is talking about, it's the same template

@wooorm
Copy link
Member

wooorm commented Dec 15, 2022

You removed the part that says “don’t remove this” (<!--do not edit: pr-->) ;)

@github-actions github-actions bot added 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Dec 15, 2022
@wooorm wooorm changed the title fix: Fix the 'plugins to remarkPlugins' deprecation message Fix typo in plugins -> remarkPlugins deprecation message Dec 15, 2022
@wooorm wooorm merged commit 402fea3 into remarkjs:main Dec 15, 2022
@wooorm
Copy link
Member

wooorm commented Dec 15, 2022

Thanks!

@github-actions

This comment has been minimized.

@wooorm wooorm added 🐛 type/bug This is a problem 💪 phase/solved Post is done labels Dec 15, 2022
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Dec 15, 2022
wooorm pushed a commit that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 phase/solved Post is done 🐛 type/bug This is a problem
Development

Successfully merging this pull request may close these issues.

None yet

3 participants