Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use node16 module resolution in tsconfig.json #723

Merged
merged 2 commits into from Jan 17, 2023
Merged

Update to use node16 module resolution in tsconfig.json #723

merged 2 commits into from Jan 17, 2023

Conversation

ChristianMurphy
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Updates TypeScript configuration to use node16 resolution for ESM.

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jan 16, 2023
@ChristianMurphy ChristianMurphy mentioned this pull request Jan 16, 2023
Merged
1 task
@ChristianMurphy
Copy link
Member Author

Depends on remarkablemark/style-to-object#47

@remarkablemark
Copy link

Depends on remarkablemark/style-to-object#47

@ChristianMurphy style-to-object@0.4.1 has been released

@ChristianMurphy
Copy link
Member Author

Thanks @remarkablemark! 🙇

@remarkjs/maintainers this is now ready for a review.

@ChristianMurphy ChristianMurphy requested a review from a team January 16, 2023 23:52
remcohaszing
remcohaszing reviewed Jan 17, 2023
View reviewed changes
tsconfig.json Outdated Show resolved Hide resolved
@ChristianMurphy @remcohaszing
remove unnecessary allowJs option from tsconfig.json
3491e38 
Co-authored-by: Remco Haszing <remcohaszing@gmail.com>
Signed-off-by: Christian Murphy <christian.murphy.42@gmail.com>
@wooorm wooorm changed the title types: node 16 module resolution Update to use node16 module resolution in tsconfig.json Jan 17, 2023
@wooorm wooorm merged commit d640d40 into remarkjs:main Jan 17, 2023
@ChristianMurphy ChristianMurphy deleted the types/node16 branch January 17, 2023 18:27
@github-actions

This comment has been minimized.

Sign in to view
@wooorm wooorm added ☂️ area/types This affects typings 💪 phase/solved Post is done labels Jan 17, 2023
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remcohaszing remcohaszing remcohaszing approved these changes

@wooorm wooorm wooorm approved these changes

Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ChristianMurphy @remarkablemark @remcohaszing @wooorm